RE: [PATCH] scsi: ufs: Fix incorrect bit assignment for temperature notifications

[Avri Altman]

+ Bao

> According to the UFS specification, the bit positions for
> `UFS_DEV_HIGH_TEMP_NOTIF` and `UFS_DEV_LOW_TEMP_NOTIF` were
> incorrectly assigned. This patch corrects the bit assignment to align with the
> specification.
> 
> If this issue is not fixed, devices that support both high and low temperature
> notifications may function correctly, but devices that support only one of
> them may fail to trigger the corresponding exception event.
> 
> Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature notification
> support")
> Signed-off-by: Keoseong Park <keosung.park@xxxxxxxxxxx>
Already noticed by Bao D. Nguyen - see https://www.spinics.net/lists/linux-scsi/msg202162.html

Thanks,
Avri

> ---
>  include/ufs/ufs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h index
> d335bff1a310..8a24ed59ec46 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -385,8 +385,8 @@ enum {
> 
>  /* Possible values for dExtendedUFSFeaturesSupport */  enum {
> -	UFS_DEV_LOW_TEMP_NOTIF		= BIT(4),
> -	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(5),
> +	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(4),
> +	UFS_DEV_LOW_TEMP_NOTIF		= BIT(5),
>  	UFS_DEV_EXT_TEMP_NOTIF		= BIT(6),
>  	UFS_DEV_HPB_SUPPORT		= BIT(7),
>  	UFS_DEV_WRITE_BOOSTER_SUP	= BIT(8),
> --
> 2.25.1
> 
>