Re: [PATCH net-next 3/3] net: phy: marvell-88q2xxx: enable temperature sensor in mv88q2xxx_config_init

[Andrew Lunn]

On Fri, Feb 14, 2025 at 05:32:05PM +0100, Dimitri Fedrau wrote:
> Temperature sensor gets enabled for 88Q222X devices in
> mv88q222x_config_init. Move enabling to mv88q2xxx_config_init because
> all 88Q2XXX devices support the temperature sensor.
> 
> Signed-off-by: Dimitri Fedrau <dima.fedrau@xxxxxxxxx>

The change itself looks fine:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

but is the sensor actually usable if the PHY has not yet been
configured?

Architecturally, it seems odd to register the HWMON in probe, and then
enable it in config_init.

    Andrew