Re: [PATCH v2] perf tools: Fix compile error on sample->user_regs

From: Namhyung Kim
Date: Fri Feb 14 2025 - 16:22:52 EST


On Fri, Feb 14, 2025 at 11:50:42AM -0800, Ian Rogers wrote:
> On Fri, Feb 14, 2025 at 11:16 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > It's recently changed to allocate dynamically but misses to update some
> > arch-dependent codes to use perf_sample__user_regs().
> >
> > Fixes: dc6d2bc2d893a878 ("perf sample: Make user_regs and intr_regs optional")
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> Thanks for this! My tag in case it is useful:
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Sure, thanks for the review.

>
> Would be nice to have asan testing to make sure there are arch
> dependent memory leaks, less arch code would be nice.

Right, I need cross-arch or native non-x86 testing.

Thanks,
Namhyung