Re: [PATCH net-next 2/2] net: cadence: macb: Report standard stats
From: Jakub Kicinski
Date: Sat Feb 15 2025 - 11:41:05 EST
On Sat, 15 Feb 2025 00:14:35 +0100 Andrew Lunn wrote:
> Could we maybe have one central table which drivers share? I assume
> IETF defined these bands as part or RMON?
IIRC RMON standardizes these three:
{ 0, 64 },
{ 65, 127 },
{ 128, 255 },
{ 256, 511 },
{ 512, 1023 },
{ 1024, 1518 },
Once we get into jumbo (as you probably noticed) the tables start
to diverge, mostly because max MTU is different.
On one hand common code is nice, on the other I don't think defining
this table has ever been a source of confusion, and common table won't
buy users anything. But, would be yet another thing we have to check
in review, no?