Re: [PATCH v5 08/16] x86/stackprotector/64: Convert to normal percpu variable

From: Borislav Petkov
Date: Sat Feb 15 2025 - 16:19:35 EST


On Sat, Feb 15, 2025 at 12:38:21PM -0500, Brian Gerst wrote:
> The convention appears to me to be that all caps are used for global
> variables used by the core build scripts and/or exported to
> subdirectory makefiles, whereas lower case is for local variables.

First time I hear of such a convention:

$ git grep -w ACCUMULATE_OUTGOING_ARGS
arch/x86/Makefile:213: ACCUMULATE_OUTGOING_ARGS := 1
arch/x86/Makefile:217:ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1)

That one should be lowercase too I guess.

> PS. Please comment on the most recent patch series, v6.

Ok.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette