Re: [PATCH] net: stmmac: Use str_enabled_disabled() helper

[Huacai Chen]

On Sun, Feb 16, 2025 at 12:44 AM Yu-Chun Lin <eleanor15x@xxxxxxxxx> wrote:
>
> As kernel test robot reported, the following warning occurs:
>
> cocci warnings: (new ones prefixed by >>)
> >> drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c:582:6-8: opportunity for str_enabled_disabled(on)
>
> Replace ternary (condition ? "enabled" : "disabled") with
> str_enabled_disabled() from string_choices.h to improve readability,
> maintain uniform string usage, and reduce binary size through linker
> deduplication.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502111616.xnebdSv1-lkp@xxxxxxxxx/
> Signed-off-by: Yu-Chun Lin <eleanor15x@xxxxxxxxx>
Reviewed-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>

> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
> index 96bcda0856ec..3efee70f46b3 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
> @@ -16,6 +16,7 @@
>  #include <linux/slab.h>
>  #include <linux/ethtool.h>
>  #include <linux/io.h>
> +#include <linux/string_choices.h>
>  #include "stmmac.h"
>  #include "stmmac_pcs.h"
>  #include "stmmac_ptp.h"
> @@ -633,7 +634,7 @@ int dwmac1000_ptp_enable(struct ptp_clock_info *ptp,
>                 }
>
>                 netdev_dbg(priv->dev, "Auxiliary Snapshot %s.\n",
> -                          on ? "enabled" : "disabled");
> +                          str_enabled_disabled(on));
>                 writel(tcr_val, ptpaddr + PTP_TCR);
>
>                 /* wait for auxts fifo clear to finish */
> --
> 2.43.0
>
>