Re: [PATCH v5 10/12] iio: adc: xilinx-xadc-core: use devm_kmemdup_array()

[Jonathan Cameron]

On Wed, 12 Feb 2025 11:55:11 +0530
Raag Jadav <raag.jadav@xxxxxxxxx> wrote:

> Convert to use devm_kmemdup_array() and while at it, use source size
> instead of destination.
> 
> Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx>

Seems fine to me.
Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

> ---
>  drivers/iio/adc/xilinx-xadc-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index cfbfcaefec0f..e1f8740ae688 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1245,8 +1245,8 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, unsigned int *conf, int irq)
>  		channel_templates = xadc_us_channels;
>  		max_channels = ARRAY_SIZE(xadc_us_channels);
>  	}
> -	channels = devm_kmemdup(dev, channel_templates,
> -				sizeof(channels[0]) * max_channels, GFP_KERNEL);
> +	channels = devm_kmemdup_array(dev, channel_templates, max_channels,
> +				      sizeof(*channel_templates), GFP_KERNEL);
>  	if (!channels)
>  		return -ENOMEM;
>