Re: [PATCH v2 12/14] iio: accel: adxl345: add inactivity feature

[Jonathan Cameron]

On Mon, 10 Feb 2025 11:01:17 +0000
Lothar Rubusch <l.rubusch@xxxxxxxxx> wrote:

> Add the inactivity feature of the sensor. When activity and inactivity
> is enabled, a link bit will be set linking activity and inactivity

are enabled, a link...

> handling. Additionally, the auto-sleep mode will be enabled. Due to the
> link bit the sensor is going to auto-sleep when inactivity was
> detected.
> 
> Inactivity detection needs a threshold to be configured, and a time
> after which it will go into inactivity state if measurements under
> threshold.
> 
> When a ODR is configured this time for inactivity is adjusted with a
> corresponding reasonable default value, in order to have higher
> frequencies and lower inactivity times, and lower sample frequency but
> give more time until inactivity. Both with reasonable upper and lower
> boundaries, since many of the sensor's features (e.g. auto-sleep) will
> need to operate beween 12.5 Hz and 400 Hz. This is a default setting
> when actively changing sample frequency, explicitly setting the time
> until inactivity will overwrite the default.
> 
> Similarly, setting the g-range will provide a default value for the
> activity and inactivity thresholds. Both are implicit defaults, but
> equally can be overwritten to be explicitly configured.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx>
A few things follow through from earlier patches (I'll assume you'll
apply those throughout).  Otherwise LGTM.