RE: [PATCH v2 01/16] x86/mce: Don't remove sysfs if thresholding sysfs init fails

From: Zhuo, Qiuxu
Date: Mon Feb 17 2025 - 01:58:28 EST


> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Sent: Friday, February 14, 2025 12:46 AM
> To: x86@xxxxxxxxxx; Luck, Tony <tony.luck@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx;
> Smita.KoralahalliChannabasappa@xxxxxxx; Yazen Ghannam
> <yazen.ghannam@xxxxxxx>; stable@xxxxxxxxxxxxxxx
> Subject: [PATCH v2 01/16] x86/mce: Don't remove sysfs if thresholding sysfs
> init fails
>
> Currently, the MCE subsystem sysfs interface will be removed if the
> thresholding sysfs interface fails to be created. A common failure is due to
> new MCA bank types that are not recognized and don't have a short name
> set.
>
> The MCA thresholding feature is optional and should not break the common
> MCE sysfs interface. Also, new MCA bank types are occasionally introduced,
> and updates will be needed to recognize them. But likewise, this should not
> break the common sysfs interface.
>
> Keep the MCE sysfs interface regardless of the status of the thresholding sysfs
> interface.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

LGTM.
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>