RE: [PATCH v2 02/16] x86/mce/amd: Remove return value for mce_threshold_create_device()

From: Zhuo, Qiuxu
Date: Mon Feb 17 2025 - 02:12:06 EST


> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Sent: Friday, February 14, 2025 12:46 AM
> To: x86@xxxxxxxxxx; Luck, Tony <tony.luck@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx;
> Smita.KoralahalliChannabasappa@xxxxxxx; Yazen Ghannam
> <yazen.ghannam@xxxxxxx>
> Subject: [PATCH v2 02/16] x86/mce/amd: Remove return value for
> mce_threshold_create_device()
>
> The return value is no longer checked, so set return type to 'void'.
>

This change can also be applied to mce_threshold_remove_device().

> Also, move function declarations to internal.h, since this function is only used
> within the MCE subsystem.

This change can also be applied to mce_threshold_remove_device().

So, can we also apply the two changes above for mce_threshold_remove_device()
in this patch?

-Qiuxu