Re: [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory node

[Krzysztof Kozlowski]

On 17/02/2025 06:27, niravkumar.l.rabara@xxxxxxxxx wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>
> 
> Add GPIO led and memory node for Agilex5 devkit.
> 
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>
> ---
>  .../boot/dts/intel/socfpga_agilex5_socdk.dts  | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> index c533e5a3a610..59530eada2ea 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> @@ -15,6 +15,25 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};

Missing blank line

> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led1 {

led-0

> +			label = "hps_led1";
> +			gpios = <&porta 11 GPIO_ACTIVE_HIGH>;
> +		};
> +

And that's not necessary

> +	};
> +


Best regards,
Krzysztof