Re: [PATCH v3 2/4] [PATCH V2 2/4] staging:gpib:agilent_82350b: Removed commented out code
From: Dan Carpenter
Date: Mon Feb 17 2025 - 08:37:48 EST
On Mon, Feb 17, 2025 at 04:00:36PM +0530, Ravi Kumar kairi wrote:
> From: Ravi Kumar Kairi <kumarkairiravi@xxxxxxxxx>
>
> Removed commented out debugging code to make code look cleaner as
> spcified by TODO
>
> Signed-off-by: Ravi Kumar Kairi <kumarkairiravi@xxxxxxxxx>
> ---
> drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> index 5a74a22015..7936c7285d 100644
> --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> @@ -176,7 +176,6 @@ static int agilent_82350b_accel_write(gpib_board_t *board, uint8_t *buffer, size
>
> event_status = read_and_clear_event_status(board);
>
> - //pr_info("ag_ac_wr: event status 0x%x tms state 0x%lx\n", event_status, tms_priv->state);
>
Same comments as for v2.
You're not supposed to mix delete comments with delete duplicate blank
lines but at the same time, you can't introduce NEW double blank line
warnings.
regards,
dan carpenter