Re: [PATCH v2 15/16] x86/mce/amd: Support SMCA Corrected Error Interrupt

From: Yazen Ghannam
Date: Mon Feb 17 2025 - 09:11:03 EST


On Thu, Feb 13, 2025 at 02:34:59PM -0800, Luck, Tony wrote:
> On Thu, Feb 13, 2025 at 04:46:04PM +0000, Yazen Ghannam wrote:
> > @@ -306,6 +306,11 @@ static void smca_configure(unsigned int bank, unsigned int cpu)
> > high |= BIT(5);
> > }
> >
> > + if ((low & BIT(10)) && data->thr_intr_en) {
> > + __set_bit(bank, data->thr_intr_banks);
> > + high |= BIT(8);
>
> Maybe someday add some #define names for these BITs?
>

Yep, I have something like that:
https://lore.kernel.org/r/20240404151359.47970-6-yazen.ghannam@xxxxxxx
https://lore.kernel.org/r/20240404151359.47970-13-yazen.ghannam@xxxxxxx

These sets keep growing, so I'm trying to do better about breaking
things up and prioritizing. :)

Thanks,
Yazen