Re: [PATCH v2 1/3] dt-bindings: iio: light: al3010: add al3000a support

[Jonathan Cameron]

On Sun, 16 Feb 2025 16:44:58 +0200
Svyatoslav Ryhel <clamor95@xxxxxxxxx> wrote:

> нд, 16 лют. 2025 р. о 16:42 Jonathan Cameron <jic23@xxxxxxxxxx> пише:
> >
> > On Sat, 15 Feb 2025 12:31:57 +0200
> > Svyatoslav Ryhel <clamor95@xxxxxxxxx> wrote:
> >  
> > > AL3000a is an ambient light sensor quite closely related to
> > > exising AL3010 and can reuse exising schema for AL3010.  
> > Hi,
> >
> > For a binding like this, also explain how they are different enough that
> > we can't use a fallback compatible.
> >
> > Thanks,
> >
> > Jonathan
> >  
> 
> Fallback will cause use of inappropriate driver. As I have already
> told, hardware configuration matches but data processing from sensor
> does not.
Absolutely understood.  The point is this patch description should
state exactly that. Say something like the register maps are incompatible.

Jonathan

> 
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > > ---
> > >  .../devicetree/bindings/iio/light/dynaimage,al3010.yaml     | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> > > index a3a979553e32..f1048c30e73e 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> > > @@ -4,14 +4,16 @@
> > >  $id: http://devicetree.org/schemas/iio/light/dynaimage,al3010.yaml#
> > >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> > >
> > > -title: Dyna-Image AL3010 sensor
> > > +title: Dyna-Image AL3000a/AL3010 sensor
> > >
> > >  maintainers:
> > >    - David Heidelberg <david@xxxxxxx>
> > >
> > >  properties:
> > >    compatible:
> > > -    const: dynaimage,al3010
> > > +    enum:
> > > +      - dynaimage,al3000a
> > > +      - dynaimage,al3010
> > >
> > >    reg:
> > >      maxItems: 1  
> >  
>