Re: [PATCH v4 0/2] Support for TI ADS7128 and ADS7138 ADCs

[Sperling, Tobias]

> Von: Jonathan Cameron <jic23@xxxxxxxxxx>
> Gesendet: Sonntag, 16. Februar 2025 16:55
>
> On Thu, 13 Feb 2025 16:58:56 +0100
> Tobias Sperling via B4 Relay <mailto:devnull+tobias.sperling.softing.com@xxxxxxxxxx>
> wrote:
> 
> > This patch series adds support for Texas Instruments ADS7128 and
> > ADS7138, which are 12-bit, 8 channel analog-to-digital converters (ADCs)
> > with build-in digital window comparator (DWC), using the I2C interface.
> >
> > The driver exposes the interfaces to read the raw values, as well as the
> > minimum and maximum value for each channel. In addition several settings
> > can be configured, like the DWC, sampling frequency or an averaging
> > filter/oversampling. Interrupts triggered by the DWC, if configured, are
> > then exposed as IIO events.
> >
> > ADS7128 differs in the addition of further hardware features, like a
> > root-mean-square (RMS) and a zero-crossing-detect (ZCD) module, which
> > are not yet supported by the driver.
> >
> > Regarding the I2C interface the chips using opcodes to define the way
> > how the registeres are accessed, like single or multiple register(s)
> > read/write or setting/clearing only bits.
> LGTM. Applied to the togreg branch of iio.git and pushed out initially
> as testing for 0-day to take a look at it.
> 
> I did notice whilst applying that the Kconfig ordering for these TI parts
> has gotten scrambled. So at some point we should clean that up and
> bring them back into alphanumeric order!
> 
> Jonathan

Ok, thanks for the info. Then everything is going its way I guess. :)

I can prepare a patch for the ordering. Shall this be based on top
of this patch set or just the master branch?

Tobias