Re: [PATCH v3 4/6] scripts/sorttable: Zero out weak functions in mcount_loc table

[Steven Rostedt]

On Fri, 14 Feb 2025 23:14:26 +0100
Jiri Olsa <olsajiri@xxxxxxxxx> wrote:

> > +	while (fscanf(fp, "%16s %16s %c %*s\n", addr_str, size_str, &type) == 3) {
> > +		uint64_t addr;
> > +		uint64_t size;
> > +
> > +		/* Only care about functions */
> > +		if (type != 't' && type != 'T')
> > +			continue;  
> 
> hi,
> I think we need the 'W' check in here [1]

Good catch!

> 
> jirka
> 
> 
> [1] https://lore.kernel.org/bpf/20250103071409.47db1479@xxxxxxxxxxxxxxxxx/

Bah, I just pulled from patchwork and forgot about that fix.

Will send a v4.

-- Steve