Re: [PATCH v3 1/5] tpm_crb: implement driver compliant to CRB over FF-A

[Stuart Yoder]

> > +int tpm_crb_ffa_init(void)
> > +{
> > +	if (tpm_crb_ffa == NULL)
> > +		return -ENOENT;
> > +
> > +	if (IS_ERR_VALUE(tpm_crb_ffa))
> > +		return -ENODEV;
> > +
> > +	return 0;
> > +}
> > +EXPORT_SYMBOL_GPL(tpm_crb_ffa_init);
>
> Should be documented given export [1].

Ack.

> > +
> > +static int __tpm_crb_ffa_send_recieve(unsigned long func_id,
> > +		unsigned long a0, unsigned long a1, unsigned long a2)
> > +{
> > +	int ret;
> > +	const struct ffa_msg_ops *msg_ops;
>
> Reverse tree-order would be easier for brain.

Ack.

> > +
> > +	if (tpm_crb_ffa == NULL)
>
> You probably did not run checkpatch.pl with '--strict', did you? ;-)

No, did no check with --strict.  Will do that.

> > +}
> > +EXPORT_SYMBOL_GPL(tpm_crb_ffa_get_interface_version);
>
> Ditto.

Ack.


> > +}
> > +EXPORT_SYMBOL_GPL(tpm_crb_ffa_start);
>
> Ditto.

Ack

> > +++ b/drivers/char/tpm/tpm_crb_ffa.h
> > @@ -0,0 +1,30 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Copyright (C) 2024 Arm Ltd.
> > + *
> > + * Authors:
> > + * Stuart Yoder <stuart.yoder@xxxxxxx>
> > + *
> > + * Maintained by: <tpmdd-devel@xxxxxxxxxxxxxxxxxxxxx>
>
> Please, rip off this authors and maintainers clutter:
>
> 1. Git maintains authorship
> 2. MAINTAINERS takes care of the rest.

Ack

Thanks,
Stuart