Re: [PATCH v3] kasan: Don't call find_vm_area() in RT kernel
From: Andrey Konovalov
Date: Mon Feb 17 2025 - 11:30:08 EST
On Mon, Feb 17, 2025 at 4:43 PM Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
>
> > --- a/mm/kasan/report.c
> > +++ b/mm/kasan/report.c
> > @@ -370,6 +370,34 @@ static inline bool init_task_stack_addr(const void *addr)
> > sizeof(init_thread_union.stack));
> > }
> >
> > +/*
> > + * RT kernel cannot call find_vm_area() in atomic context. For !RT kernel,
> > + * prevent spinlock_t inside raw_spinlock_t warning by raising wait-type
> > + * to WAIT_SLEEP.
> > + */
>
> Do we need this comment? I lacks context of why it is atomic. And we
> have it in the commit description.
I would prefer to have this in the comment, but with a full
explanation of why this needs to be done.