Re: [PATCH v2 03/11] sched: Add sched tracepoints for RV task model

From: Peter Zijlstra
Date: Mon Feb 17 2025 - 11:49:31 EST


On Mon, Feb 17, 2025 at 11:38:44AM -0500, Steven Rostedt wrote:

> > +void __do_trace_set_current_state(int state_value)
> > +{
> > + __do_trace_sched_set_state_tp(current, current->__state, state_value);
>
> And this should not be using the internal macros of a trace point. It should be:
>
> trace_sched_set_state_tp(current, state_value);
>
> (I removed the current->__state as mentioned above).

But the static branch is already in the caller, no point duplicating
that.