Re: [PATCH RESEND v2 3/3] x86/cpu: Enable modifying bug flags with {clear,set}puid
From: Brendan Jackman
Date: Mon Feb 17 2025 - 11:56:59 EST
On Mon, 17 Feb 2025 at 12:10, Borislav Petkov <bp@xxxxxxxxx> wrote:
> > @@ -1492,7 +1492,8 @@ static inline void parse_set_clear_cpuid(char *arg, bool set)
> >
> > /*
> > * Handle naked numbers first for feature flags which don't
> > - * have names.
> > + * have names. It doesn't make sense for a bug not to have a
> > + * name so don't handle bug flags here.
> > */
> > if (!kstrtouint(opt, 10, &bit)) {
> > if (bit < NCAPINTS * 32) {
>
> It did but after
>
> 7583e8fbdc49 ("x86/cpu: Remove X86_FEATURE_NAMES")
>
> this chunk can be whacked now. Please do that in a pre-patch.
Er, hold on, what chunk can be whacked? Do you mean delete the ability
to set clearcpuid by number? There are still features with no name.