Re: [PATCH 3/4] x86/tdx: Add tdx_mcall_rtmr_extend() interface

From: Xing, Cedric
Date: Mon Feb 17 2025 - 16:00:21 EST


On 2/16/2025 6:40 PM, Huang, Kai wrote:

@@ -135,6 +136,41 @@ int tdx_mcall_get_report0(u8 *reportdata, u8 *tdreport)
  }
  EXPORT_SYMBOL_GPL(tdx_mcall_get_report0);
+/**
+ * tdx_mcall_rtmr_extend() - Wrapper to extend RTMR registers using
+ *                 TDG.MR.RTMR.EXTEND TDCALL.

Nit:  I would prefer to name it as tdx_mcall_extend_rtmr() since this matches the existing tdx_mcall_get_report0() (and tdx_hcall_get_quote()) better.  But no strong opinion.

This actually my preference too!

Sathy, what do you think?