Re: [PATCH bpf-next v2 3/6] selftests/bpf: move open_tuntap to network helpers
From: Willem de Bruijn
Date: Mon Feb 17 2025 - 20:50:49 EST
Marcus Wichelmann wrote:
> To test the XDP metadata functionality of the tun driver, it's necessary
> to create a new tap device first. A helper function for this already
> exists in lwt_helpers.h. Move it to the common network helpers header,
> so it can be reused in other tests.
>
> Signed-off-by: Marcus Wichelmann <marcus.wichelmann@xxxxxxxxxxxxxxxx>
Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx>
Both tests that include lwt_helpers.h also include network_helpers.h,
so the linking with network_helpers.o is already addressed. This was
not entirely obvious from just reading the code.