RE: [PATCH v2 05/16] x86/mce: Cleanup bank processing on init

From: Zhuo, Qiuxu
Date: Mon Feb 17 2025 - 21:15:57 EST


> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Sent: Friday, February 14, 2025 12:46 AM
> To: x86@xxxxxxxxxx; Luck, Tony <tony.luck@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx;
> Smita.KoralahalliChannabasappa@xxxxxxx; Yazen Ghannam
> <yazen.ghannam@xxxxxxx>
> Subject: [PATCH v2 05/16] x86/mce: Cleanup bank processing on init
>
> From: Borislav Petkov <bp@xxxxxxx>
>
> Unify the bank preparation into __mcheck_cpu_init_clear_banks(), rename
> that function to what it does now - prepares banks. Do this so that generic
> and vendor banks init goes first so that settings done during that init can take
> effect before the first bank polling takes place.
>
> Move __mcheck_cpu_check_banks() into
> __mcheck_cpu_init_prepare_banks() as it already loops over the banks.
>
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>

Other than Tony's comments about the missing comment for
'MCP_DONTLOG',

Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>