Re: [PATCH net-next 3/7] net: hibmcge: Add rx checksum offload supported in this module
From: Kalesh Anakkur Purayil
Date: Mon Feb 17 2025 - 21:47:05 EST
On Tue, Feb 18, 2025 at 7:47 AM Jijie Shao <shaojijie@xxxxxxxxxx> wrote:
>
>
> on 2025/2/17 23:40, Simon Horman wrote:
> > On Thu, Feb 13, 2025 at 11:55:25AM +0800, Jijie Shao wrote:
> >> This patch implements the rx checksum offload feature
> >> including NETIF_F_IP_CSUM NETIF_F_IPV6_CSUM and NETIF_F_RXCSUM
> >>
> >> Signed-off-by: Jijie Shao <shaojijie@xxxxxxxxxx>
> > ...
> >
> >> diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c
> >> index 8c631a9bcb6b..aa1d128a863b 100644
> >> --- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c
> >> +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c
> >> @@ -202,8 +202,11 @@ static int hbg_napi_tx_recycle(struct napi_struct *napi, int budget)
> >> }
> >>
> >> static bool hbg_rx_check_l3l4_error(struct hbg_priv *priv,
> >> - struct hbg_rx_desc *desc)
> >> + struct hbg_rx_desc *desc,
> >> + struct sk_buff *skb)
> >> {
> >> + bool rx_checksum_offload = priv->netdev->features & NETIF_F_RXCSUM;
> > nit: I think this would be better expressed in a way that
> > rx_checksum_offload is assigned a boolean value (completely untested).
> >
> > bool rx_checksum_offload = !!(priv->netdev->features & NETIF_F_RXCSUM);
>
> Okay, I'll modify it in v2.
Maybe you can remove " in this module" from the patch title as it is
implicit. This comment/suggestion applies to all patches in this
series.
>
> Thanks
> Jijie Shao
>
> >
> >> +
> >> if (likely(!FIELD_GET(HBG_RX_DESC_W4_L3_ERR_CODE_M, desc->word4) &&
> >> !FIELD_GET(HBG_RX_DESC_W4_L4_ERR_CODE_M, desc->word4)))
> >> return true;
>
--
Regards,
Kalesh AP
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature