RE: [PATCH v2 06/16] x86/mce: Remove __mcheck_cpu_init_early()

[Zhuo, Qiuxu]

> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Sent: Friday, February 14, 2025 12:46 AM
> To: x86@xxxxxxxxxx; Luck, Tony <tony.luck@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx;
> Smita.KoralahalliChannabasappa@xxxxxxx; Yazen Ghannam
> <yazen.ghannam@xxxxxxx>
> Subject: [PATCH v2 06/16] x86/mce: Remove __mcheck_cpu_init_early()
> 
> The __mcheck_cpu_init_early() function was introduced so that some
> vendor-specific features are detected before the first MCA polling event done
> in __mcheck_cpu_init_generic().
> 
> Currently, __mcheck_cpu_init_early() is only used on AMD-based systems
> and additional code will be needed to support various system configurations.
> 
> However, the current and future vendor-specific code should be done during
> vendor init. This keeps all the vendor code in a common location and
> simplifies the generic init flow.
> 
> Move all the __mcheck_cpu_init_early() code into mce_amd_feature_init().
> Also, move __mcheck_cpu_init_generic() after
> __mcheck_cpu_init_prepare_banks() so that MCA is enabled after the first
> MCA polling event.

Maybe providing a bit more information about the first MCA polling event, 
as shown below, would be clearer:

   "... so that MCA is enabled after the first MCA polling event for the machine 
    checks left over from the previous reset."

> Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>

Other than that,

    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>