Re: [PATCH 1/1] x86/vmemmap: Use direct-mapped VA instead of vmemmap-based VA

From: Andrew Morton
Date: Tue Feb 18 2025 - 00:43:49 EST


On Tue, 18 Feb 2025 14:27:27 +0900 "Harry Yoo (Oracle)" <42.hyeyoo@xxxxxxxxx> wrote:

> > page table when accessing a vmemmap-based virtual address before this sync.
> >
> > Fixes: faf1c0008a33 ("x86/vmemmap: optimize for consecutive sections in partial populated PMDs")
> > Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@xxxxxxxxx>
> > Cc: Oscar Salvador <osalvador@xxxxxxx>
> > Cc: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
>
> I think this fix is reasonable without changing existing code too much.
> Any thoughts from x86 folks?
>
> > Cc: Byungchul Park <byungchul@xxxxxx>
> > Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> > Cc: Andy Lutomirski <luto@xxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> Shouldn't we add Cc: <stable@xxxxxxxxxxxxxxx>?

I'd say so, yes. For many subsystems, a Fixes: means that -stable
maintainers will automatically scoop it up. For mm patches they have
been asked to not do that - such patches require an explicit cc:stable
(the MM developers wish to determine what is backported).

An explicit cc:stable removes all doubt.

Also, this patch should have cc'ed linux-mm, please.

Anyway, I'll grab it pending additional review and I'll add the
cc:stable, thanks.