Re: [PATCH 1/2] clk: qcom: gdsc: Set retain_ff before moving to HW CTRL

[Imran Shaik]

On 2/14/2025 9:56 AM, Taniya Das wrote:
> Enable the retain_ff_enable bit of GDSCR only if the GDSC is already ON.
> Once the GDSCR moves to HW control, SW no longer can determine the state
> of the GDSCR and setting the retain_ff bit could destroy all the register
> contents we intended to save.
> Therefore, move the retain_ff configuration before switching the GDSC to
> HW trigger mode.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 173722995cdb ("clk: qcom: gdsc: Add support to enable retention of GSDCR")
> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
> ---
>  drivers/clk/qcom/gdsc.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 

Reviewed-by: Imran Shaik <quic_imrashai@xxxxxxxxxxx>
Tested-by: Imran Shaik <quic_imrashai@xxxxxxxxxxx> # on QCS8300