Re: [PATCH] rust: io: rename `io::Io` accessors

From: Greg Kroah-Hartman
Date: Tue Feb 18 2025 - 02:57:15 EST


On Mon, Feb 17, 2025 at 09:58:14PM +0100, Fiona Behrens wrote:
> Rename the I/O accessors provided by `Io` to encode the type as
> number instead of letter. This is in preparation for Port I/O support
> to use a trait for generic accessors.
>
> Add a `c_fn` argument to the accessor generation macro to translate
> between rust and C names.
>
> Suggested-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> Link: https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/topic/PIO.20support/near/499460541
> Signed-off-by: Fiona Behrens <me@xxxxxxxxxx>
> ---
> rust/kernel/io.rs | 66 ++++++++++++++++++++---------------------
> samples/rust/rust_driver_pci.rs | 12 ++++----
> 2 files changed, 39 insertions(+), 39 deletions(-)

This is good, thanks!

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Want me to take this through my tree?

thanks,

greg k-h