Re: [PATCH] nvme: remove multipath module parameter

[Sagi Grimberg]

On 17/02/2025 18:14, John Meneghini wrote:
> On 2/17/25 3:08 AM, Sagi Grimberg wrote:
> > > We plan to ship this patch with RHEL-10. So it would be really good 
> > > if we could get this
> > > change accepted and merged upstream, perhaps into v6.15.
> >
> > Hey John,
> >
> > This looks fine to me, I'm assuming this was also tested with 
> > CONFIG_NVME_MULTIPATH=n ?
>
> Yes, everything has been tested with CONFIG_NVME_MULTIPATH both 
> enabled (Y) and disabled (N).
>
> As we discussed in the previous email thread[1] there is an anomaly 
> seen when you build a kernel with CONFIG_NVME_MULTIPATH=n.
> and the host discovers a multipath capable nvme device (CMIC/NMIC=1). 
> You will see exactly the same thing that you do with
> CONFIG_NVME_MULTIPATH=y when the nvme_core.multipath parameter is N. 
> You see a separate /dev/nvmeNN entry for
> every namespace/controller path.
>
> We can send send a separate patch to address that problem, but this 
> patch, which simply removes the nvme_core.multipath parameter
> has beeen fully tested and is ready to go.

I think that we want to print a warning in this case though. Can you 
resubmit with logging a warning in this case?