Re: [PATCH v2 1/2] media: dt-bindings: Add dt bindings for m2m-deinterlace device

[Krzysztof Kozlowski]

On Fri, Feb 14, 2025 at 06:17:58PM -0500, Matthew Majewski wrote:
> Create a new yaml schema file to describe the device tree bindings for
> generic m2m-deinterlace device.
> 
> This device is supported on any hardware that provides a MEM_TO_MEM

Which device? I don't see here any device name/model.

I asked to provide here some examples of devices.

> capable dma channel with interleaved trasfer support. Device tree
> bindings are for providing appropriate dma channel to device.

Don't describe what DT is, but the hardware.

> 
> Signed-off-by: Matthew Majewski <mattwmajewski@xxxxxxxxx>
> ---
>  .../bindings/media/m2m-deinterlace.yaml       | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml b/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
> new file mode 100644
> index 000000000000..e39599d7d07b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/m2m-deinterlace.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: M2M Deinterlacer
> +
> +maintainers:
> +  - Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> +
> +description: |-
> +  A generic memory2memory device for deinterlacing video using dmaengine. It can
> +  convert between interlaced buffer formats and can convert interlaced to
> +  progressive using a simple line-doubling algorithm. This device can be used on
> +  any hardware that provides a MEM_TO_MEM capable dma controller that supports
> +  interleaved transfers.

And how do you program that device to deinterlace? How do you signal end
of frame/data when writing to the memory?

It still looks all this is for driver :/

Best regards,
Krzysztof