Re: [PATCH v2 0/2] drm: bridge: add ssd2825 RGB/DSI bridge support

[Svyatoslav Ryhel]

вт, 18 лют. 2025 р. о 14:36 Thomas Zimmermann <tzimmermann@xxxxxxx> пише:
>
> (cc'ing Javier)
>
> Hi
>
> Am 17.02.25 um 15:09 schrieb Svyatoslav Ryhel:
> > Solomon SSD2825 is a RGB to MIPI DSI bridge used in LG Optimus 4D P880
> > and LG Optimus Vu P895
>
> There's a driver for Solomon 13xx displays in drm/solomon. Did you check
> that this new driver isn't just an extension of the existing code?
>

Definitely no, ssd2825 is a RGB to DSI bridge in a pure form. While
13xx as you have said are display controllers family.

> Best regards
> Thomas
>
> >
> > ---
> > Changes on switching from v1 to v2:
> > - added description for clock
> > - removed clock-names
> > - added boundries for hs-zero-delay-ns and hs-prep-delay-ns
> > - added mutex lock for host transfers
> > - converted to atomic ops
> > - get drm_display_mode mode with atomic helpers
> > - parameterized INTERFACE_CTRL_REG_6 configuration
> > - added video mode validation and fixup
> > - removed clock name
> > - switched to devm_regulator_bulk_get_const
> > - added default timings
> > ---
> >
> > Svyatoslav Ryhel (2):
> >    dt-bindings: display: bridge: Document Solomon SSD2825
> >    drm: bridge: Add support for Solomon SSD2825 RGB/DSI bridge
> >
> >   .../display/bridge/solomon,ssd2825.yaml       | 141 +++
> >   drivers/gpu/drm/bridge/Kconfig                |  14 +
> >   drivers/gpu/drm/bridge/Makefile               |   1 +
> >   drivers/gpu/drm/bridge/ssd2825.c              | 824 ++++++++++++++++++
> >   4 files changed, 980 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/display/bridge/solomon,ssd2825.yaml
> >   create mode 100644 drivers/gpu/drm/bridge/ssd2825.c
> >
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
>