Re: [PATCH 2/2] irqchip: clocksource: fix jcore-pit irq request

From: Rob Landley
Date: Tue Feb 18 2025 - 09:02:08 EST


On 2/16/25 11:55, Artur Rojek wrote:
The jcore-aic irqchip does not have separate interrupt numbers reserved
for cpu-local vs global interrupts. Instead, the task of selecting this
property is being delegated to the device drivers requesting the given
irq.

This quirk has not been taken into account while migrating jcore-pit to
request_percpu_irq(), resulting in a failure to register PIT interrupts.

Fix this behavior by making the following changes:
1) Explicitly register irq_set_percpu_devid() in jcore-pit.
2) Provide enable_percpu_irq()/disable_percpu_irq() calls in jcore-pit.
3) Make jcore-aic pass the correct per-cpu cookie to the irq handler by
using handle_percpu_devid_irq() instead of handle_percpu_irq().

Fixes: 69a9dcbd2d65 ("clocksource/drivers/jcore: Use request_percpu_irq()")

Signed-off-by: Artur Rojek <contact@xxxxxxxxxxxxxx>

Tested-by: Rob Landley <rob@xxxxxxxxxxx>

Rob