Re: [PATCH 3/5] reset: imx8mp-audiomix: Introduce active_low configuration option

[Peng Fan]

On Tue, Feb 18, 2025 at 10:57:10AM +0200, Daniel Baluta wrote:
>For EARC and EARC PHY the reset happens when clearing the reset bits.
>Refactor assert/deassert function in order to take into account
>the active_low configuratin option.
>
>Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx>
>---
> drivers/reset/reset-imx8mp-audiomix.c | 45 ++++++++++++++-------------
> 1 file changed, 23 insertions(+), 22 deletions(-)
>
>diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
>index 6b1666c4e069..8cc0a6b58cbc 100644
>--- a/drivers/reset/reset-imx8mp-audiomix.c
>+++ b/drivers/reset/reset-imx8mp-audiomix.c
>@@ -23,16 +23,19 @@
> struct imx8mp_reset_map {
> 	unsigned int offset;
> 	unsigned int mask;
>+	bool active_low;

How about using u32 flags?
Then it will be easy to extend to add new FLAG in future in case.

If you tend to use bool, also ok to me:

Reviewed-by: Peng Fan <peng.fan@xxxxxxx>