Re: [PATCH v6 06/15] x86/module: Deal with GOT based stack cookie load on Clang < 17

[Brian Gerst]

On Tue, Feb 18, 2025 at 4:07 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Brian Gerst <brgerst@xxxxxxxxx> wrote:
>
> >  #define R_X86_64_GOTPCREL    9       /* 32 bit signed pc relative
> > -                                        offset to GOT */
> > +#define R_X86_64_GOTPCRELX   41         offset to GOT */
>                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > +#define R_X86_64_REX_GOTPCRELX       42
>
> Uhm, I'm pretty sure this won't even build, should any code use
> R_X86_64_GOTPCRELX - which it doesn't currently...
>
> Also, each entry here has a comment explaining it - except these two
> new GOTPCREL variants.

Should we remove the non-REX version that isn't used by the kernel?
This header is not exported to userspace.


Brian Gerst