Re: [PATCH v2 17/29] ASoC: tas2764: Crop SDOUT zero-out mask based on BCLK ratio

From: Martin Povišer
Date: Tue Feb 18 2025 - 10:55:44 EST



> On 18. 2. 2025, at 16:25, Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Tue, Feb 18, 2025 at 06:35:51PM +1000, James Calligeros wrote:
>> From: Martin Povišer <povik+lin@xxxxxxxxxxx>
>>
>> Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
>> Signed-off-by: Martin Povišer <povik+lin@xxxxxxxxxxx>
>> Signed-off-by: James Calligeros <jcalligeros99@xxxxxxxxx>
>
> Again, why do this? Is this a bug fix of some kind (ie, does the
> hardware misbehave if we get this wrong) or is it just for neatness?

James,

I’ve found the language in the datasheet which made me make this change:

"This register to be programmed as zero in case the slot is not valid as per valid FSRATIO”

Martin