Re: [PATCH net-next 1/3] net: phy: marvell-88q2xxx: align defines
From: Russell King (Oracle)
Date: Tue Feb 18 2025 - 11:01:15 EST
On Tue, Feb 18, 2025 at 12:54:29PM +0100, Marek Behún wrote:
> > +#define MDIO_MMD_AN_MV_STAT 32769
>
> Why the hell are register addresses in this driver in decimal?
Shocker - some documentation gives driver addresses for PHYs in
decimal.
It then becomes a pain to have to manually translate back and
forth between hex and decimal if one is reading the driver code and
referring back to the documentation.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!