Re: [PATCH] nvme: remove multipath module parameter

[John Meneghini]

On 2/18/25 9:26 AM, John Meneghini wrote:
> > +    } else {
> > +#ifdef CONFIG_NVME_MULTIPATH
> >           sprintf(disk->disk_name, "nvme%dn%d", ctrl->subsys->instance,
> >               ns->head->instance);
> > -    } else {
>  > +#else
>
> You don't need the this #ifdef conditional statement because the nvme_ns_head_multipath() function checks CONFIG_NVME_MULTIPATH
> for you and the sprintf(disk->disk_name, "nvme%dn%d" statement is kind of redundant.
>
>
> >           sprintf(disk->disk_name, "nvme%dn%d", ctrl->instance,
> >               ns->head->instance);
> > +#endif 

Actually, I think I may be wrong about this.  To maintain 100% backward compatibility with what the users see in the dmesg log, I think we need this code.

/John