Re: [PATCH] objtool: Use idiomatic section name for relocatable rodata under PIE
From: Josh Poimboeuf
Date: Tue Feb 18 2025 - 13:31:17 EST
On Tue, Feb 18, 2025 at 06:44:23PM +0100, Ard Biesheuvel wrote:
> > If I understand correctly, this is fixing an existing bug in loongarch
> > and any other arches using PIE, right?
>
> There are no other arches using PIE as far as I know. But it indeed
> fixes an oversight in how -fPIE is used in the kernel.
>
> > And it has nothing to do with
> > objtool?
> >
>
> That didn't stop you from taking the previous fix :-)
The whole point of the previous fix was to fix a bug in the objtool
annotations. Unlike your patch, it didn't have any intended side
effects.
> > If so, it feels like this needs to be its own patch, described as a fix.
> >
>
> Fair enough. But better to drop the previous patch from the objtool tree then.
I think we can do that... Peter?
And just to be clear, you'll have two fixes, right?
1) Make loongarch .data.rel.ro.* actually read-only
2) Fix objtool C jump table annotations for clang
--
Josh