Re: [PATCH net-next v3] af_unix: Fix undefined 'other' error

[Kuniyuki Iwashima]

From: Purva Yeshi <purvayeshi550@xxxxxxxxx>
Date: Tue, 18 Feb 2025 19:40:45 +0530
> Fix an issue detected by the Smatch static analysis tool where an
> "undefined 'other'" error occurs due to `__releases(&unix_sk(other)->lock)`
> being placed before 'other' is in scope.

I don't care much, but according to Dan, this is Sparse error due to
const unix_sk() ?

https://lore.kernel.org/all/bbf51850-814a-4a30-8165-625d88f221a5@stanley.mountain/

> 
> Remove the `__releases()` annotation from the `unix_wait_for_peer()`
> function to eliminate the Smatch warning. The annotation references `other`

Same here ?


> before it is declared, leading to a false positive error during static
> analysis.
> 
> Since AF_UNIX does not use Sparse annotations, this annotation is
> unnecessary and does not impact functionality.
> 
> Signed-off-by: Purva Yeshi <purvayeshi550@xxxxxxxxx>

Anyway,

Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>

Also, I think you can carry over Joe and Simon's tags as the change is
trivial.