Re: [PATCH v2 1/4] HID: apple: Use common table for MacBook Pro fn mapping
From: Aditya Garg
Date: Tue Feb 18 2025 - 15:09:04 EST
Hi Jiri
> On 19 Feb 2025, at 1:29 AM, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>
> On Fri, 14 Feb 2025, Aditya Garg wrote:
>
>> From: Aditya Garg <gargaditya08@xxxxxxxx>
>>
>> The only difference between the fn mapping of the MacBook Pros with esc key
>> and those without is of the presence of KEY_GRAVE in the translation table.
>>
>> We can easily use a flag instead of writing the whole table again to omit
>> it from the models that have an esc key.
>>
>> Additionally, APPLE_IGNORE_MOUSE quirk was unused in this driver, so has
>> been removed in this commit.
>>
>> Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx>
>> ---
>
> Why am I getting v1, [RESEND v1] and v2 in the timespan of 1 day without
> any documentation whatsoever what are the changes between the individual
> submission and why do we have so many of them?
I'll make sure changelog is provided next time.
RESEND was done because I forgot to Cc the mailing lists. Its my fault here
V2: I was suggested to use switch case by a colleague later that day, so added 4/4
>
> Thanks in advance for clarification,
>
> --
> Jiri Kosina
> SUSE Labs