Re: [PATCH v3] docs: iostats: Rewrite intro, remove outdated formats

From: Jonathan Corbet
Date: Tue Feb 18 2025 - 15:57:34 EST


David Reaver <me@xxxxxxxxxxxxxxx> writes:

> The introduction discussed stat file formats for very old kernel versions,
> which obscured key information that readers may find useful. Additionally,
> the example file contents and the reference to "15 fields" did not account
> for the flush fields added in b6866318657 ("block: add iostat counters for
> flush requests") [1].
>
> Rewrite the introduction to focus only on the current kernel's disk I/O stat
> file formats. Also, clean up wording for conciseness.
>
> Link: https://lore.kernel.org/lkml/157433282607.7928.5202409984272248322.stgit@buzz/T/ [1]
>
> Signed-off-by: David Reaver <me@xxxxxxxxxxxxxxx>
> ---
>
> Lore links to previous versions:
> V1: https://lore.kernel.org/linux-doc/20250214013905.60526-1-me@xxxxxxxxxxxxxxx/
> V2: https://lore.kernel.org/linux-doc/20250214051432.207630-1-me@xxxxxxxxxxxxxxx/
>
> Changes:
> V1 -> V2: Rewrite entire introduction instead of just changing 15 -> 17.
> V2 -> V3: Reword counter reset paragraph for accuracy and clarity.
>
> Documentation/admin-guide/iostats.rst | 89 ++++++++++-----------------
> 1 file changed, 33 insertions(+), 56 deletions(-)

This seems like a definite improvement at this point. Applied, thanks.

jn