Re: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue

[Jiri Kosina]

On Thu, 13 Feb 2025, Even Xu wrote:

> Change to use "||" to make it more readable and avoid miss
> understanding.
> 
> Signed-off-by: Even Xu <even.xu@xxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@xxxxxxxxx
> ---
>  drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> index eb23bea77686..8f97e71df7f4 100644
> --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> @@ -295,7 +295,7 @@ static void release_dma_buffers(struct thc_device *dev,
>  		return;
>  
>  	for (i = 0; i < config->prd_tbl_num; i++) {
> -		if (!config->sgls[i] | !config->sgls_nent[i])
> +		if (!config->sgls[i] || !config->sgls_nent[i])
>  			continue;

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs