RE: [PATCH v2 4/7] irqchip/renesas-rzv2h: Add rzv2h_icu_register_dma_req_ack

From: Fabrizio Castro
Date: Tue Feb 18 2025 - 17:10:59 EST


Hi Thomas,

Thanks for your feedback!

> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Sent: 18 February 2025 08:00
> Subject: Re: [PATCH v2 4/7] irqchip/renesas-rzv2h: Add rzv2h_icu_register_dma_req_ack
>
> On Wed, Feb 12 2025 at 22:13, Fabrizio Castro wrote:
> > On the Renesas RZ/V2H(P) family of SoCs, DMAC IPs are connected
> > to the Interrupt Control Unit (ICU).
> > For DMA transfers, a request number and an ack number must be
> > registered with the ICU, which means that the DMAC driver has
> > to be able to instruct the ICU driver with the registration of
> > such ids.
> >
> > Export rzv2h_icu_register_dma_req_ack so that the DMA driver
> > can register both ids in one go.
>
> Please denote functions in the subject and change log body as fun()
> according to documentation:

Thanks for pointing this out. I'll address it in the next version.

Cheers,
Fab

>
> https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#function-references-in-changelogs
>
> With that fixed:
>
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> under the assumption that this will be merged via the dmaengine tree.
>
> Thanks,
>
> tglx