Re: [PATCH] m68k: mm: Replace deprecated strncpy() with strscpy()

[Greg Ungerer]

Hi Thorsten,

On 19/2/25 00:13, Geert Uytterhoeven wrote:
> On Thu, 13 Feb 2025 at 15:11, Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
> > strncpy() is deprecated for NUL-terminated destination buffers. Use
> > strscpy() instead and remove the manual NUL-termination.
> >
> > Compile-tested only.
> >
> > Link: https://github.com/KSPP/linux/issues/90
> > Cc: linux-hardening@xxxxxxxxxxxxxxx
> > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
>
> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> > --- a/arch/m68k/kernel/setup_mm.c
> > +++ b/arch/m68k/kernel/setup_mm.c
> > @@ -243,8 +243,7 @@ void __init setup_arch(char **cmdline_p)
> >          setup_initial_init_mm((void *)PAGE_OFFSET, _etext, _edata, _end);
> >
> >   #if defined(CONFIG_BOOTPARAM)
> > -       strncpy(m68k_command_line, CONFIG_BOOTPARAM_STRING, CL_SIZE);
> > -       m68k_command_line[CL_SIZE - 1] = 0;
> > +       strscpy(m68k_command_line, CONFIG_BOOTPARAM_STRING, CL_SIZE);
> >   #endif /* CONFIG_BOOTPARAM */
> >          process_uboot_commandline(&m68k_command_line[0], CL_SIZE);
> >          *cmdline_p = m68k_command_line;
>
> This seems to be used mostly by Coldfire, so I'll let Greg handle it.

Looks good. Pushed into the m68knommu git tree, for-next branch, with
JM's tested-by and Geert's reviewed-by added.

Thanks
Greg