Re: [PATCH net-next v2] net: Remove redundant variable declaration in __dev_change_flags()
From: patchwork-bot+netdevbpf
Date: Tue Feb 18 2025 - 21:22:58 EST
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:
On Mon, 17 Feb 2025 07:48:13 -0800 you wrote:
> The old_flags variable is declared twice in __dev_change_flags(),
> causing a shadow variable warning. This patch fixes the issue by
> removing the redundant declaration, reusing the existing old_flags
> variable instead.
>
> net/core/dev.c:9225:16: warning: declaration shadows a local variable [-Wshadow]
> 9225 | unsigned int old_flags = dev->flags;
> | ^
> net/core/dev.c:9185:15: note: previous declaration is here
> 9185 | unsigned int old_flags = dev->flags;
> | ^
> 1 warning generated.
>
> [...]
Here is the summary with links:
- [net-next,v2] net: Remove redundant variable declaration in __dev_change_flags()
https://git.kernel.org/netdev/net-next/c/8f02c48f8f62
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html