Re: [PATCH v2 1/5] net: phy: bcm63xx: add support for BCM63268 GPHY
From: kernel test robot
Date: Tue Feb 18 2025 - 23:21:17 EST
Hi Kyle,
kernel test robot noticed the following build warnings:
[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on robh/for-next lee-leds/for-leds-next linus/master lee-mfd/for-mfd-fixes v6.14-rc3 next-20250218]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kyle-Hendry/net-phy-bcm63xx-add-support-for-BCM63268-GPHY/20250218-094117
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link: https://lore.kernel.org/r/20250218013653.229234-2-kylehendrydev%40gmail.com
patch subject: [PATCH v2 1/5] net: phy: bcm63xx: add support for BCM63268 GPHY
config: x86_64-buildonly-randconfig-004-20250219 (https://download.01.org/0day-ci/archive/20250219/202502191212.s0NqhQ3T-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250219/202502191212.s0NqhQ3T-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502191212.s0NqhQ3T-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/net/phy/bcm63xx.c:84:5: warning: no previous prototype for function 'bcm63268_gphy_set' [-Wmissing-prototypes]
84 | int bcm63268_gphy_set(struct phy_device *phydev, bool enable)
| ^
drivers/net/phy/bcm63xx.c:84:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
84 | int bcm63268_gphy_set(struct phy_device *phydev, bool enable)
| ^
| static
>> drivers/net/phy/bcm63xx.c:100:5: warning: no previous prototype for function 'bcm63268_gphy_resume' [-Wmissing-prototypes]
100 | int bcm63268_gphy_resume(struct phy_device *phydev)
| ^
drivers/net/phy/bcm63xx.c:100:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
100 | int bcm63268_gphy_resume(struct phy_device *phydev)
| ^
| static
>> drivers/net/phy/bcm63xx.c:115:5: warning: no previous prototype for function 'bcm63268_gphy_suspend' [-Wmissing-prototypes]
115 | int bcm63268_gphy_suspend(struct phy_device *phydev)
| ^
drivers/net/phy/bcm63xx.c:115:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
115 | int bcm63268_gphy_suspend(struct phy_device *phydev)
| ^
| static
3 warnings generated.
vim +/bcm63268_gphy_set +84 drivers/net/phy/bcm63xx.c
83
> 84 int bcm63268_gphy_set(struct phy_device *phydev, bool enable)
85 {
86 struct bcm_gphy_priv *priv = phydev->priv;
87 u32 pwr_bits;
88 int ret;
89
90 pwr_bits = GPHY_CTRL_IDDQ_BIAS | GPHY_CTRL_LOW_PWR;
91
92 if (enable)
93 ret = regmap_update_bits(priv->gphy_ctrl, 0, pwr_bits, 0);
94 else
95 ret = regmap_update_bits(priv->gphy_ctrl, 0, pwr_bits, pwr_bits);
96
97 return ret;
98 }
99
> 100 int bcm63268_gphy_resume(struct phy_device *phydev)
101 {
102 int ret;
103
104 ret = bcm63268_gphy_set(phydev, true);
105 if (ret)
106 return ret;
107
108 ret = genphy_resume(phydev);
109 if (ret)
110 return ret;
111
112 return 0;
113 }
114
> 115 int bcm63268_gphy_suspend(struct phy_device *phydev)
116 {
117 int ret;
118
119 ret = genphy_suspend(phydev);
120 if (ret)
121 return ret;
122
123 ret = bcm63268_gphy_set(phydev, false);
124 if (ret)
125 return ret;
126
127 return 0;
128 }
129
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki