Re: [PATCH v3 1/5] dt-bindings: clock: add clock definitions for exynos7870 CMU

From: Krzysztof Kozlowski
Date: Wed Feb 19 2025 - 03:07:28 EST


On Wed, Feb 19, 2025 at 12:20:28AM +0530, Kaustabh Chakraborty wrote:
> Add unique identifiers for exynos7870 clocks for every bank. It adds all
> clocks of CMU_MIF, CMU_DISPAUD, CMU_G3D, CMU_ISP, CMU_MFCMSCL, and
> CMU_PERI.
>
> Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> ---
> include/dt-bindings/clock/exynos7870.h | 324 +++++++++++++++++++++++++++++++++
> 1 file changed, 324 insertions(+)

Again, you keep repeating some old patterns ignoring what was added
recently. This must match compatible, so missing vendor prefix.

Also squash the patch with the binding itself so you will see the
difference in names.

Best regards,
Krzysztof