Re: [PATCH v4 6/8] reset: eyeq: drop device_set_of_node_from_dev() done by parent
From: Philipp Zabel
Date: Wed Feb 19 2025 - 04:27:38 EST
On Di, 2025-02-18 at 20:29 +0100, Jerome Brunet wrote:
> From: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>
> Our parent driver (clk-eyeq) now does the
> device_set_of_node_from_dev(dev, dev->parent)
> call through the newly introduced devm_auxiliary_device_create() helper.
>
> Doing it again in the reset-eyeq probe would be redundant.
> Drop both the WARN_ON() and the device_set_of_node_from_dev() call.
> Also fix the following comment that talks about "our newfound OF node".
>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
regards
Philipp