Re: [PATCH 2/2] can: flexcan: add transceiver capabilities

[Marc Kleine-Budde]

On 19.02.2025 11:39:55, Dimitri Fedrau wrote:
> > > diff --git a/drivers/net/can/flexcan/flexcan.h b/drivers/net/can/flexcan/flexcan.h
> > > index 4933d8c7439e62b5d6fcc445d88c2b5ccbfa13bb..56be40875eee24aee9297c4bc7c2fc4380e682ff 100644
> > > --- a/drivers/net/can/flexcan/flexcan.h
> > > +++ b/drivers/net/can/flexcan/flexcan.h
> > > @@ -103,6 +103,7 @@ struct flexcan_priv {
> > >  	struct clk *clk_per;
> > >  	struct flexcan_devtype_data devtype_data;
> > >  	struct regulator *reg_xceiver;
> > > +	struct phy *xceiver;
> > 
> > All other drivers name this variable "transceiver", does it make sense
> > to use this name here, too?
> > 
> I have no preference on this, but my intention was to name it xceiver
> according to reg_xceiver, so people familiar with the code would know
> what it is about. I can change it to transceiver, what do you think ?

Please use transceiver.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature