Re: [PATCH] arm: clk: Add ETH switch clock description for vf610 SoC

[Fabio Estevam]

Hi Lukasz,

On Wed, Feb 19, 2025 at 9:06 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> This defiine should not change. If you need to change it, means it is
> not an ABI. Just like for other cases, I suggest to drop the define in
> preparatory patch.

You can follow the same approach that was done for i.MX93.

Please check the two commits below:

commit c0813ce2e5b0d1174782aff30d366509377abc7b
Author: Pengfei Li <pengfei.li_1@xxxxxxx>
Date:   Wed Oct 23 11:46:48 2024 -0700

    dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition

    IMX93_CLK_END should be dropped as it is not part of the ABI.

    Signed-off-by: Pengfei Li <pengfei.li_1@xxxxxxx>
    Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
    Acked-by: Peng Fan <peng.fan@xxxxxxx>
    Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
    Link: https://lore.kernel.org/r/20241023184651.381265-3-pengfei.li_1@xxxxxxx
    Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>


commit 0af18ba60752e8a4ba34404c1d9a4a799da690f5
Author: Pengfei Li <pengfei.li_1@xxxxxxx>
Date:   Wed Oct 23 11:46:47 2024 -0700

    clk: imx93: Move IMX93_CLK_END macro to clk driver

    IMX93_CLK_END was previously defined in imx93-clock.h to indicate
    the number of clocks. However, it is not part of the ABI. For starters
    it does no really appear in DTS. But what's more important - new clocks
    are described later, which contradicts this define in binding header.
    So move this macro to clock driver.

    Signed-off-by: Pengfei Li <pengfei.li_1@xxxxxxx>
    Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20241023184651.381265-2-pengfei.li_1@xxxxxxx
    Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>

Also, the Subject should not contain 'arm'. You could use:

clk: vf610: Add support for the Ethernet switch clock